Fix catalog connection failure due to AppCapability::CreateWithProcessIdForUser throwing E_INVALIDARG when called with a null user on Windows 10 v1903 #5475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppCapability::CreateWithProcessIdForUser throwing E_INVALIDARG when called with a null user on Windows 10 v1903 `AppCapability::CreateWithProcessIdForUser` does not accept a null user on Windows 10 v1903. Treat this case as if the API didn't exist.
JohnMcPMS
reviewed
May 22, 2025
There was a problem hiding this comment.
I spent quite a while trying to find a way to get a non-null User to pass, but never found one that works for us. I did find the change that made null work, but it ultimately ends up ignoring the value, not using it as a signal to retrieve some default.
So while it irks me, I will not make the perfect stand in the way of the good.
yao-msft
reviewed
May 22, 2025
Yea, |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppCapability::CreateWithProcessIdForUserdoes not accept a null user on Windows 10 v1903. Treat this case as if the API didn't exist.Fixes #5378.
Microsoft Reviewers: Open in CodeFlow