-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Create a vcpkg overlay for cpprestsdk and libyaml #5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
# Conflicts: # src/cpprestsdk/cpprestsdk.vcxproj
# Conflicts: # src/AppInstallerCommonCore/AppInstallerCommonCore.vcxproj # src/AppInstallerSharedLib/AppInstallerSharedLib.vcxproj
JohnMcPMS
reviewed
May 5, 2025
@@ -33,7 +33,7 @@ | |||
"type": "git", | |||
"git": { | |||
"repositoryUrl": "https://github.com/microsoft/sfs-client.git", | |||
"commitHash": "ff315ecfa2ef2953d8a808e51e8a61a4e0759180" | |||
"commitHash": "2c891fc7a770e8ba2fec34fc6b545c672beb37e6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to update the SFS Client entry? It appears to be a libyaml commit hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not. Fixed now to add libyaml
JohnMcPMS
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a local port overlay so that we can have our own custom vcpkg ports. In particular we use it to:
These ports are mostly a copy of the official ports, but with the patches we want applied. Unfortunately the original port recipes were already applying some patches, and we had to include them here because vcpkg provides no mechanism to apply a single additional patch on top of an existing port.
Notes for the future:
Microsoft Reviewers: Open in CodeFlow