Enable NuGet Central Package Management #5420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
commented
May 1, 2025
There was a problem hiding this comment.
It took me a while to catch this, but this file is independent of Directory.Build.props
JohnMcPMS
reviewed
May 1, 2025
...osoft.Management.Configuration.Processor/Microsoft.Management.Configuration.Processor.csproj
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Microsoft.WinGet.Client.Engine.csproj
Outdated
Show resolved
Hide resolved
florelis
commented
May 1, 2025
| <PackageVersion Include="System.Private.Uri" Version="4.3.2" /> | ||
| <PackageVersion Include="System.Security.Principal.Windows" Version="5.0.0" /> | ||
| <PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" /> | ||
| <PackageVersion Include="xunit" Version="2.4.2" /> |
There was a problem hiding this comment.
I just realized that we use both nunit and xunit in different projects, which seems a bit weird
JohnMcPMS
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the NuGet Central Package Management feature to streamline dependency management. Key benefits and changes include:
Centralized Version Management: All NuGet package versions are now managed centrally in the
Directory.Packages.propsfile. This ensures consistency across all projects in the repository.Simplified Project Files: The individual project files are simplified, as they no longer need to specify version numbers for NuGet packages. This change reduces duplication and the potential for version conflicts.
Ease of Updating Dependencies: Updating a package version is now a matter of changing it in one place, making the process of keeping dependencies up-to-date more straightforward and less error-prone.
(Description copied from the automated PR to the internal repo :D )
Microsoft Reviewers: Open in CodeFlow