Remove clones of transitive dependencies available from vcpkg #5399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
Apr 21, 2025
Merged
florelis
added a commit
that referenced
this pull request
May 3, 2025
In #5399 I changed purelib from using a vcxproj to using a vcxitems, but didn't remove the vcxproj. This PR removes the vcxprojs, and moves the include path from the consumers to purelib.vcxitems ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5429)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5390
We have copies of
PureLibandUndockedRegFreeWinRTin the repo that themselves include code from their dependencies (catch2,zlib). This PR removes that code in favor of using vcpkg to fetch the dependencies.For
PureLib, after removingzlib, there are only headers left. So I replaced the.vcxprojwith a.vcxitemsFor
UndockedRegFreeWinRT, I removed all the test code along with the copy of catch2.Updated the READMEs for the subtrees, although I'm not certain a subtree update would still work...
Microsoft Reviewers: Open in CodeFlow