Lower Schema Header Validation to include 1.7+ manifests #5330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ahhhh, I forgot the tests :( |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yao-msft - Would you be able to help me understand what tests are failing? I don’t seem to be able to find them from my end |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Copilot has failed me :( |
|
I've run the tests on my machine and they succeed (except for the one unrelated one that always fails), so hopefully it will work this time
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Finally! Thanks for all the patience!! |
yao-msft
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many contributors to the community repository may not upgrade to schema 1.10 unless necessary to do so, as there were no additional fields in the manifest that are usable in the community repository. In addition to manifest creation tools lagging behind a little bit (as of this PR, both Komac and WingetCreate are still at version 1.9 manifests), some submitters use mechanisms outside of these tools which use older manifest versions.
This first PR changes the schema header validation so that it happens for any manifest schema 1.7 or newer to cover a larger range of submissions.
I have manually validated this change against every manifest currently in the community repository. Three had to be corrected, and now none are failing validation
Microsoft Reviewers: Open in CodeFlow