Skip to content

Update winget.resw #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Update winget.resw #5279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7ca2e
Update winget.resw
pressRtowin Mar 7, 2025
2fd7043
Update winget.resw
pressRtowin Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
<value>This command requires administrator privileges to execute.</value>
</data>
<data name="CompleteCommandLongDescription" xml:space="preserve">
<value>This command can be used to request context sensitive command line completion. The command line, cursor position, and word to be completed are passed in. The output is a set of potential values based on the inputs, one possible value per line.</value>
<value>This command can be used to request context sensitive command line completion. The command line, cursor position, and word to be completed are passed in. The output is a set of potential values based on the inputs, with one possible value per line.</value>
</data>
<data name="CompleteCommandShortDescription" xml:space="preserve">
<value>Enables context sensitive command line completion</value>
Expand Down Expand Up @@ -1025,11 +1025,11 @@ Configuration is disabled due to Group Policy.</value>
<comment>{Locked="{0}","{1}"} Error message displayed when an attempt to get a preferred installer for a manifest fails. {0} is a placeholder replaced by the manifest identifier. {1} is a placeholder replaced by the manifest version.</comment>
</data>
<data name="DependenciesManagementError" xml:space="preserve">
<value>Error processing package dependencies, do you wish to continue installation?</value>
<value>Error processing package dependencies. Do you wish to continue installation?</value>
<comment>Prompt message shown when dependencies processing yields errors.</comment>
</data>
<data name="DependenciesManagementExitMessage" xml:space="preserve">
<value>Error processing package dependencies, exiting...</value>
<value>Error processing package dependencies. Exiting...</value>
</data>
<data name="PackageDependencies" xml:space="preserve">
<value>Packages</value>
Expand Down Expand Up @@ -1379,7 +1379,7 @@ Please specify one of them using the --source option to proceed.</value>
<value>Prompts the user to press any key before exiting</value>
</data>
<data name="InstallerElevationExpected" xml:space="preserve">
<value>The installer will request to run as administrator, expect a prompt.</value>
<value>The installer will request to run as administrator. Expect a prompt.</value>
</data>
<data name="InstallerProhibitsElevation" xml:space="preserve">
<value>The installer cannot be run from an administrator context.</value>
Expand Down Expand Up @@ -1444,7 +1444,7 @@ Please specify one of them using the --source option to proceed.</value>
<value>Purging install directory...</value>
</data>
<data name="UnableToPurgeInstallDirectory" xml:space="preserve">
<value>Cannot purge install directory, as it was not created by winget</value>
<value>Cannot purge install directory as it was not created by winget</value>
</data>
<data name="RelatedLink" xml:space="preserve">
<value>Related Link</value>
Expand Down Expand Up @@ -1597,7 +1597,7 @@ Please specify one of them using the --source option to proceed.</value>
<value>Version to which to pin the package. The wildcard '*' can be used as the last version part</value>
</data>
<data name="PinAddBlockingArgumentDescription" xml:space="preserve">
<value>Block from upgrading until the pin is removed, preventing override arguments</value>
<value>Block from upgrading until the pin is removed, preventing override arguments.</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only here and not the next line, and every other description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was Ctrl + f-ing through the doc for commas tbh and wasn't looking at other lines. As for why not every other description, hard to know if a period is necessary without knowing the context it's presented in, especially for shorter ones that aren't technically full sentences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are definitely more fixes that could be made, but as far as I can tell, the ones I proposed are still valid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the context: All the ones with name ending in ArgumentDescription are what is shown when you do --help for a command. Not sure if we should have a period or not in those, but it should be consistent since it's a pretty well defined category

</data>
<data name="PinInstalledArgumentDescription" xml:space="preserve">
<value>Pin a specific installed version</value>
Expand Down Expand Up @@ -2086,7 +2086,7 @@ Please specify one of them using the --source option to proceed.</value>
<comment>{Locked="%LOCALAPPDATA%\Microsoft\WinGet\Configuration\Modules"}</comment>
</data>
<data name="ConfigurationModulePathArgError" xml:space="preserve">
<value>`--module-path` value must be `currentuser`, `allusers`, `default` or an absolute path.</value>
<value>`--module-path` value must be `currentuser`, `allusers`, `default`, or an absolute path.</value>
<comment>{Locked="{--module-path}, {currentuser}, {allusers}, {default}}</comment>
</data>
<data name="PolicyEnableWinGetConfiguration" xml:space="preserve">
Expand Down Expand Up @@ -2147,7 +2147,7 @@ Please specify one of them using the --source option to proceed.</value>
<value>The source type is invalid</value>
</data>
<data name="APPINSTALLER_CLI_ERROR_PACKAGE_IS_BUNDLE" xml:space="preserve">
<value>The MSIX file is a bundle, not a package</value>
<value>The MSIX file is a bundle, not a package.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like most other strings for error codes don't end with a period, but some do. Not sure which one is better, but if we're changing it we should make it consistent across the board

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there was already quite a bit of inconsistency. I tried to catch what I could and push it towards "more correct". For periods, as I mentioned in my other comment, I wasn't explicitly looking for them so I didn't change much except when the line also contained a comma, but generally I tried to stick with "Is this actually a sentence?" and (to my best guess) "Is this being used in a kind of setting where formatting it with a period makes sense?".

Copy link
Contributor Author

@pressRtowin pressRtowin Mar 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also because of the nature of where these strings are used, there are also a lot of strings that aren't technically grammatically correct (e.g. "Does this" instead of "It/This does this.", or "Thing required" instead of "A thing is required." etc.). But that kind of language is pretty common in this setting (and whether or not it should be, or if it's "correct" is basically a whole philosophical debate at this point lol), so I avoided touching stuff like that to just not open that whole can of worms.

</data>
<data name="APPINSTALLER_CLI_ERROR_SOURCE_DATA_MISSING" xml:space="preserve">
<value>Data required by the source is missing</value>
Expand Down Expand Up @@ -2360,7 +2360,7 @@ Please specify one of them using the --source option to proceed.</value>
<value>Portable package from a different source already exists.</value>
</data>
<data name="APPINSTALLER_CLI_ERROR_PORTABLE_SYMLINK_PATH_IS_DIRECTORY" xml:space="preserve">
<value>Unable to create symlink, path points to a directory.</value>
<value>Unable to create symlink. Path points to a directory.</value>
</data>
<data name="APPINSTALLER_CLI_ERROR_INSTALLER_PROHIBITS_ELEVATION" xml:space="preserve">
<value>The installer cannot be run from an administrator context.</value>
Expand Down Expand Up @@ -2755,7 +2755,7 @@ Please specify one of them using the --source option to proceed.</value>
<comment>{Locked="WinGetPackage,{0}"}</comment>
</data>
<data name="AuthenticationModeArgumentDescription" xml:space="preserve">
<value>Specify authentication window preference (silent, silentPreferred or interactive)</value>
<value>Specify authentication window preference (silent, silentPreferred, or interactive)</value>
<comment>{Locked="silent","silentPreferred","interactive"} This argument allows the user to select authentication window popup behavior.</comment>
</data>
<data name="AuthenticationAccountArgumentDescription" xml:space="preserve">
Expand Down Expand Up @@ -3207,4 +3207,4 @@ Please specify one of them using the --source option to proceed.</value>
<data name="ConfigurationProcessorPath" xml:space="preserve">
<value>Specify the path to the configuration processor</value>
</data>
</root>
</root>
Loading