Skip to content

Add max nest level limit to yaml parser #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2025
Merged

Add max nest level limit to yaml parser #5275

merged 3 commits into from
Mar 5, 2025

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Mar 5, 2025 •
edited by microsoft-github-policy-service bot
Loading

This fixes an oom issue found in fuzzing run.

Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner March 5, 2025 08:58
JohnMcPMS
JohnMcPMS approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can achieve this with recursive references as well. I would guess that is what fuzzing stumbled into.

@yao-msft
Copy link
Contributor Author

yao-msft commented Mar 5, 2025

I think you can achieve this with recursive references as well. I would guess that is what fuzzing stumbled into.

Yes, fuzzing test failed on a recursive reference.

@yao-msft
Copy link
Contributor Author

yao-msft commented Mar 5, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit 9c2c635 into microsoft:master Mar 5, 2025
9 checks passed
@yao-msft yao-msft deleted the oomfixtest branch March 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yao-msft @JohnMcPMS