-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Python: Introduce NvidiaChatCompletion AI Connector #12952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soumilinandi
wants to merge
16
commits into
microsoft:main
Choose a base branch
from
soumilinandi:feature/chat-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree company="NVIDIA" |
moonbox3
reviewed
Sep 1, 2025
python/semantic_kernel/connectors/ai/nvidia/services/nvidia_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/nvidia/services/nvidia_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/nvidia/services/nvidia_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/nvidia/services/nvidia_chat_completion.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/nvidia/services/nvidia_chat_completion.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/ai/nvidia/services/nvidia_chat_completion.py
Show resolved
Hide resolved
moonbox3
approved these changes
Sep 11, 2025
TaoChenOSU
approved these changes
Sep 11, 2025
Python Test Coverage Report •
Python Unit Test Overview
|
Hi @soumilinandi, mypy is failing with a few errors, FYI: https://github.com/microsoft/semantic-kernel/actions/runs/17649725903/job/50177819907?pr=12952#step:6:8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change adds chat completion support with structured output to the existing NVIDIA connector, enabling developers to use NVIDIA's chat models through Semantic Kernel while building conversational AI applications that require structured, validated responses. The connector will support more model types iteratively, with future PRs introducing VLM models and additional capabilities.
Description
New Chat Completion Service:
NvidiaChatCompletion
: Chat completion service following same structure as other connectorsEnhanced Configuration:
NvidiaChatPromptExecutionSettings
: Chat-specific settings following existing connector patternsContribution Checklist