Skip to content

Update telemetry test to use localId instead of deviceId for consistency #15144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Update telemetry test to use localId instead of deviceId for consistency #15144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
083bba4
Fix to retrieve deviceId
Sep 13, 2025
cf39cdb
Change files
Sep 13, 2025
a4b51e1
Merge branch 'main' into user/harinimalothu/FixToRetrieveDeviceId
HariniMalothu17 Sep 17, 2025
810d702
Update change/@react-native-windows-telemetry-e8822c8e-55c2-4622-b9ef…
HariniMalothu17 Sep 17, 2025
7170d00
Update change/@react-native-windows-telemetry-e8822c8e-55c2-4622-b9ef…
HariniMalothu17 Sep 17, 2025
b00c483
update localID and deviceClass to populate in partB
Sep 17, 2025
014fd1f
Merge branch 'user/harinimalothu/FixToRetrieveDeviceId' of https://gi…
Sep 17, 2025
3b8aa82
Update packages/@react-native-windows/telemetry/src/telemetry.ts
HariniMalothu17 Sep 17, 2025
e72a73f
Merge branch 'main' into user/harinimalothu/FixToRetrieveDeviceId
HariniMalothu17 Sep 18, 2025
f02161a
Update packages/@react-native-windows/telemetry/src/e2etest/telemetry…
jonthysell Sep 18, 2025
f6b12b1
Merge branch 'main' into user/harinimalothu/FixToRetrieveDeviceId
HariniMalothu17 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@react-native-windows-telemetry-e8822c8e-55c2-4622-b9ef-48a80761ca6a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix to retrieve deviceId",
"packageName": "@react-native-windows/telemetry",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 5 additions & 0 deletions packages/@react-native-windows/telemetry/src/e2etest/telemetry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,11 @@ function verifyTestCommandTelemetryProcessor(
// Verify basics
const commonProperties = properties!.common;
expect(commonProperties.commandName).toBe('test-command');
// Verify LocalId
const expectedLocalId = TelemetryTest.getCommonProperty('deviceId');
expect(envelope.ext?.device?.localId).toBeDefined();
expect(envelope.ext?.device?.localId).toBe(expectedLocalId);
expect(commonProperties.device?.localId).toBe(expectedLocalId); // Only if you know it's set in the event, not in static commonProperties

// Verify versions info
const versions = properties!.versions;
Expand Down
4 changes: 3 additions & 1 deletion packages/@react-native-windows/telemetry/src/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export class Telemetry {
// Populate Part A extensions
telemetryItem.ext = {};
telemetryItem.ext.device = {
id: Telemetry.commonProperties.deviceId,
localId: Telemetry.commonProperties.deviceId,
deviceClass: Telemetry.commonProperties.deviceClass,
};
telemetryItem.ext.os = {
Expand All @@ -385,6 +385,8 @@ export class Telemetry {
numCPUs: Telemetry.commonProperties.numCPUs,
totalMemory: Telemetry.commonProperties.totalMemory,
diskFreeSpace: Telemetry.commonProperties.deviceDiskFreeSpace,
localId: Telemetry.commonProperties.deviceId,
deviceClass: Telemetry.commonProperties.deviceClass,
},
nodePlatform: Telemetry.commonProperties.nodePlatform,
nodeArchitecture: Telemetry.commonProperties.nodeArchitecture,
Expand Down
Loading