Skip to content

[Fabric] Fix for updating accessibility value in UIA #14858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

[Fabric] Fix for updating accessibility value in UIA #14858

merged 2 commits into from
Jul 14, 2025

Conversation

vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Jul 10, 2025 •
edited
Loading

Description

Update the Value prop in UIA whenever it changes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

Resolves : microsoft/react-native-gallery/issues/605

What

will update accessibilityValue in UIA whenever it changes.

Screenshots

<TouchableOpacity
          accessibilityRole="button"
          accessibilityLabel={'example TouchableOpacity counter'}
          accessibilityHint={'click me to increase the example counter'}
          accessibilityValue={{text: `${title}`}}
          onPress={() => {
            setTitle(title + 1);
          }}
          onAccessibilityTap={() => {
            setTitle(title + 1);
          }}
          activeOpacity={0.8}>
          <Text>{String(title)}</Text>
</TouchableOpacity>

Copied this gallery code and tested in playground
Before Changes:

Narrator.Before.mp4

After Changes:

Narrator.After.mp4

The narrator will announce if accessibility value changed.

Testing

Tested in playground.

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

@vineethkuttan vineethkuttan marked this pull request as ready for review July 11, 2025 05:22
@vineethkuttan vineethkuttan requested a review from a team as a code owner July 11, 2025 05:22
anupriya13
anupriya13 approved these changes Jul 12, 2025
View reviewed changes
Copy link
Contributor

@anupriya13 anupriya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏻

@satkh satkh self-requested a review July 13, 2025 15:41
This was referenced Jul 14, 2025
Closed
Merged
@HariniMalothu17
Copy link
Contributor

lgtm

@vineethkuttan vineethkuttan merged commit b054122 into microsoft:main Jul 14, 2025
58 checks passed
christophpurrer pushed a commit to christophpurrer/react-native-windows that referenced this pull request Jul 15, 2025
@vineethkuttan @christophpurrer
[Fabric] Fix for updating accessibility value in UIA (microsoft#14858)
807fd79 
* Changes for updating accessibilityValue prop

* Change files
@vineethkuttan vineethkuttan deleted the updatingAccessibilityValue branch July 17, 2025 09:31
@vineethkuttan
Copy link
Contributor Author

#12361 This is also fixed

@vineethkuttan vineethkuttan mentioned this pull request Jul 23, 2025
Closed
@vineethkuttan vineethkuttan mentioned this pull request Aug 2, 2025
Closed
4 tasks
acoates-ms pushed a commit to acoates-ms/react-native-windows that referenced this pull request Sep 11, 2025
@vineethkuttan @acoates-ms
[Fabric] Fix for updating accessibility value in UIA (microsoft#14858)
b0cd6ed 
* Changes for updating accessibilityValue prop

* Change files
acoates-ms added a commit that referenced this pull request Sep 19, 2025
@acoates-ms @anupriya13
@iamAbhi-916 @vineethkuttan @HariniMalothu17 @chiaramooney @jonthysell @protikbiswas100
[0.74] Cherry picking various fixes (#15142)
919860a 
* Pointer events (#14713)

* PointerEvent fixes

* Change files

* format

* [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509)

* Fabric : Added support for selectionColor in TextInput component  (#14743)

* Added support for selectionColor for textInput

* yarn fix and format

* Change files

* Implement adjustsFontSizeToFit property for Text in Fabric (#14519)

* Implementation of adjustFontSizeToFit

* Final Changes using TextLayout

* Lint Issue Fixes

* Change files

* prop change detection added

* review Changes and E2E test cases added

* Lint and Format Changes added

* Test Cases Fix added

* Update SnapShot

* Removed the additional Check for resizing Font

* Updated SnapShot

* Review Changes

* Lint and Format Changes

---------

Co-authored-by: Vineeth K <[email protected]>

* Text : Added EllipsizeMode for tail and clip alignment  (#14660)

* updated ellipsis to respect tail and clip behaviour , for head , middle follow defaulty tail behaviour

* patched updateTextAlignment method

* Change files

* pathced branch , lint fix , lint format

* updated snapshots

* added layout changes to TextLayoutManager

* lint fix and format

* updated snapshots

* updated snapshot Pressable component

* updated to remove extra text_layout null check

* removed comments

* format and lint:fix

* [Fabric] Implement onContentSizeChange in TextInput (#14785)

* Fix : adjustsFontSizeToFit just redrawing won't recalculate the layout (#14813)

* updated adjustsFontSizeToFit textlayout to nullptr

* Change files

* [Fabric] Implement autoFocus property for TextInput for fabric  (#14816)

* Added fix for AutoFocus

* Change files

---------

Co-authored-by: Harini Malothu <[email protected]>

* [Fabric] Implementation of accessibilityDescription (#14818)

* Initial Commit for accessibilityDescription

* Change files

* Format Changes

* Updating Snapshot

* [Fabric] Implement maxFontSizeMultiplier in Text Input (#14639)

* [Fabric] Fix for updating accessibility value in UIA (#14858)

* Changes for updating accessibilityValue prop

* Change files

* TextInput should capture mouse on mouse down (#14983)

* TextInput should capture mouse on mouse down

* Change files

* format

* [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023)

* Update Toggle State to Narrator

* Yarn Change

* Review Changes

* Review Changes 2.0

* [Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider (#14332)

* Partial Implementation

* Add More Implementation

* More Implementation

* More Implementation

* Add Support for Bounding Rectangles

* Complete Initial Implementation

* Change files

* Code Cleanup

* Code Cleanup

* Update Snapshots + Code Cleanup

* Update Snapshots

* Address Feedback

* Address Feedback

* Update Snapshots

* Fix Tests

---------

Co-authored-by: Jon Thysell <[email protected]>

* [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088)

* Few more implementation of TextRange Provider

* Yarn change

* Update Change file

* Screen reader fails to announce the expand/collapse state of the navigation button (#15106)

* adding UIA event handler changes for navigator

* Change files

* adding ViewComponent chnages for accessibility

* removing unnecessary change file

* Remove vnext/fmt/packages.lock.json

---------

Co-authored-by: Protik Biswas <[email protected]>

* fix

* fix

* Upgrade dotnet version

* Change files

* bump sdk

* bump node

* fix

* fix

* Change files

* fix

* fix

* test

* fix

* fix

* update snapshots

* snapshot

* snapshot

* measureLines

* fix

* snapshot

---------

Co-authored-by: Anupriya Verma <[email protected]>
Co-authored-by: Abhijeet Jha <[email protected]>
Co-authored-by: Vineeth <[email protected]>
Co-authored-by: Vineeth K <[email protected]>
Co-authored-by: Harini Malothu <[email protected]>
Co-authored-by: Harini Malothu <[email protected]>
Co-authored-by: Chiara Mooney <[email protected]>
Co-authored-by: Jon Thysell <[email protected]>
Co-authored-by: Protik Biswas <[email protected]>
Co-authored-by: Protik Biswas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamAbhi-916 iamAbhi-916 iamAbhi-916 approved these changes

@anupriya13 anupriya13 anupriya13 approved these changes

@HariniMalothu17 HariniMalothu17 HariniMalothu17 approved these changes

@chiaramooney chiaramooney Awaiting requested review from chiaramooney

+1 more reviewer

@satkh satkh satkh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug 58167046: [React Native New Architecture]: Narrator remains silent on invoking the 'TouchableOpacity counter' button.
5 participants
@vineethkuttan @HariniMalothu17 @anupriya13 @iamAbhi-916 @satkh