-
Notifications
You must be signed in to change notification settings - Fork 67
Add indirect connection support #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@hfhongzy please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Thanks @hfhongzy, let me go through the paper first. Since we introduced |
Hi @hfhongzy, I have a question for your PR. From your implementation, seems you can create your own connection by inherits from the namespace your_namespace {
class IndirectConnection : public mscclpp::Connection {
...
};
}; Then create the connection via I think MSCCL++ should support customized p2p connection, trying to better understand your requirements |
Hi @Binyang2014, thanks for your reply! I believe we (University of Michigan) have been discussing with Changho @chhwang about adding this feature in MSCCL++. Apologies for the confusion here. |
This PR introduces a new feature called indirect connection, enabling data transfer from endpoint A to endpoint C via forwarding through endpoint B. It defines two abstractions: buffer resources (send and receive buffers on the forwarding endpoint) and scheduler (which manages the data movement logic). We provide an implementation based on Vortex (Yichao, Lin, and Nishil. https://arxiv.org/abs/2502.09541), which uses a toggling double buffer and a pipeline style to overlap the two transfer paths efficiently.