Enabling app notification tests #5781
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "Description": "App Notification Tests Packaged", | ||
| "Filename": "AppNotificationTests.dll", | ||
| "Parameters": "/name:PackagedTests*", | ||
| "Architectures": ["x64", "x86"], |
There was a problem hiding this comment.
Are these tests not configured to run for ARM64? Just checking if there's a gap in coverage or if it's intentional.
There was a problem hiding this comment.
Yes, the tests are currently not being built for arm64.
|
|
||
| if (status == winrt::Windows::Foundation::AsyncStatus::Error) | ||
| { | ||
| VERIFY_THROWS_HR(removeNotificationAsync.GetResults(), E_INVALIDARG); |
There was a problem hiding this comment.
Has there been any investigation into why x86 is exhibiting different behavior or returning an error compared to x64? Catching the error and rethrowing only on INVALID_ARG might inadvertently mask other underlying issues.
There was a problem hiding this comment.
I don't know why, but this was happening in two x86 machines in a consistent manner. We can also disable this test if that is desired.
There was a problem hiding this comment.
Let's keep the current workaround in place to ensure we have a basic test case running. However, we should also create a work item to track investigation for x86 support and add a TODO comment to remove this workaround once resolved. As part of this work item, let's also include looking into building tests for arm64 to ensure broader coverage.
This PR enables App notification tests.
The changes on this PR include:
:Classfrom theRunAsproperty for the unpackaged tests. This scope prevents the inheritance of the property value by the methods, making the methods being executed in the same scope as the main test, which isSystem. App notifications needs to be run in a non elevated process, which requires integrity level of medium or lower. For that reason, the previous configuration was breaking the tests, so now the test methods are run inRestrictedUserscope alongside the class methods, making everything run in the same process..testdeffile and copying it as other tests.A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.