Sort imports with dprint instead of eslint #58058
Merged
+13
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
Apr 3, 2024
sheetalkamat
approved these changes
Apr 3, 2024
jakebailey
commented
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few people have expressed that they'd prefer if the formatter did this rather than eslint. dprint can do this a lot faster without the linter errors; if you save on format it'll be extra good.
The downside is that we will lose automatic grouping, until maybe dprint/dprint-plugin-typescript#493. That's something I was relying on in #51455 to ensure the namespace imports always came first, but that could be achieved another way.
I also discovered dprint/dprint-plugin-typescript#620, but that's not a very bad bug.
I had to disable formatting in
_namespaces, as those import orders matter and dprint does not have the ability to ignore regions: dprint/dprint-plugin-typescript#411