Skip to content

Switch to var in binder for top level variables #52903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2023
Merged

Switch to var in binder for top level variables #52903

merged 2 commits into from
Feb 22, 2023

Conversation

jakebailey
Copy link
Member

Followup to #52832 and others.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 21, 2023
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 21, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at e7c5b69. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52903
Metric main 52903 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,704k (± 0.01%) 359,624k (± 0.02%) -80k (- 0.02%) 359,549k 359,692k p=0.013 n=6
Parse Time 3.48s (± 0.42%) 3.50s (± 0.78%) ~ 3.47s 3.54s p=0.373 n=6
Bind Time 1.18s (± 0.44%) 1.12s (± 0.46%) 🟩-0.05s (- 4.53%) 1.12s 1.13s p=0.004 n=6
Check Time 8.74s (± 0.34%) 8.83s (± 0.39%) +0.09s (+ 0.99%) 8.79s 8.89s p=0.005 n=6
Emit Time 7.57s (± 0.35%) 7.67s (± 0.86%) +0.09s (+ 1.19%) 7.56s 7.74s p=0.036 n=6
Total Time 20.98s (± 0.13%) 21.11s (± 0.39%) +0.14s (+ 0.65%) 20.99s 21.22s p=0.008 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 190,904k (± 1.24%) 191,728k (± 1.49%) ~ 189,821k 195,435k p=0.471 n=6
Parse Time 1.48s (± 1.16%) 1.48s (± 0.95%) ~ 1.46s 1.50s p=1.000 n=6
Bind Time 0.79s (± 0.52%) 0.77s (± 0.82%) -0.02s (- 2.74%) 0.76s 0.78s p=0.003 n=6
Check Time 9.44s (± 0.61%) 9.48s (± 0.75%) ~ 9.40s 9.56s p=0.521 n=6
Emit Time 2.79s (± 0.67%) 2.81s (± 1.23%) ~ 2.76s 2.85s p=0.625 n=6
Total Time 14.51s (± 0.42%) 14.54s (± 0.48%) ~ 14.45s 14.65s p=0.575 n=6
Monaco - node (v18.10.0, x64)
Memory used 344,083k (± 0.01%) 344,024k (± 0.01%) ~ 343,956k 344,061k p=0.128 n=6
Parse Time 2.61s (± 1.07%) 2.63s (± 0.98%) ~ 2.60s 2.67s p=0.156 n=6
Bind Time 1.04s (± 1.32%) 1.01s (± 0.80%) -0.02s (- 2.25%) 1.00s 1.02s p=0.015 n=6
Check Time 7.13s (± 0.66%) 7.13s (± 0.57%) ~ 7.05s 7.16s p=0.935 n=6
Emit Time 4.32s (± 0.87%) 4.33s (± 0.40%) ~ 4.30s 4.35s p=0.747 n=6
Total Time 15.09s (± 0.34%) 15.10s (± 0.22%) ~ 15.07s 15.16s p=0.573 n=6
TFS - node (v18.10.0, x64)
Memory used 300,071k (± 0.01%) 300,003k (± 0.01%) -67k (- 0.02%) 299,977k 300,033k p=0.005 n=6
Parse Time 2.06s (± 0.73%) 2.04s (± 1.06%) -0.03s (- 1.29%) 2.01s 2.06s p=0.040 n=6
Bind Time 1.17s (± 0.35%) 1.14s (± 0.36%) -0.03s (- 2.57%) 1.13s 1.14s p=0.003 n=6
Check Time 6.58s (± 0.65%) 6.56s (± 0.66%) ~ 6.52s 6.63s p=0.630 n=6
Emit Time 3.92s (± 0.73%) 3.92s (± 0.64%) ~ 3.89s 3.95s p=1.000 n=6
Total Time 13.73s (± 0.51%) 13.66s (± 0.45%) ~ 13.61s 13.77s p=0.126 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,416k (± 0.00%) 476,312k (± 0.01%) -104k (- 0.02%) 476,282k 476,350k p=0.005 n=6
Parse Time 3.15s (± 0.99%) 3.18s (± 0.52%) ~ 3.15s 3.19s p=0.251 n=6
Bind Time 0.97s (± 0.42%) 0.91s (± 0.69%) 🟩-0.06s (- 6.02%) 0.90s 0.92s p=0.003 n=6
Check Time 17.25s (± 1.01%) 17.23s (± 0.32%) ~ 17.16s 17.32s p=0.688 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.37s (± 0.84%) 21.31s (± 0.27%) ~ 21.25s 21.41s p=0.748 n=6
xstate - node (v18.10.0, x64)
Memory used 548,605k (± 0.02%) 548,426k (± 0.04%) ~ 548,250k 548,777k p=0.066 n=6
Parse Time 4.08s (± 0.63%) 4.06s (± 0.62%) ~ 4.02s 4.09s p=0.259 n=6
Bind Time 1.74s (± 0.79%) 1.67s (± 0.82%) 🟩-0.06s (- 3.55%) 1.65s 1.69s p=0.005 n=6
Check Time 2.82s (± 0.43%) 2.83s (± 0.93%) ~ 2.80s 2.87s p=0.870 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.72s (± 0.35%) 8.64s (± 0.42%) -0.08s (- 0.88%) 8.58s 8.69s p=0.006 n=6
Angular - node (v16.17.1, x64)
Memory used 359,025k (± 0.01%) 358,968k (± 0.01%) -57k (- 0.02%) 358,944k 359,016k p=0.013 n=6
Parse Time 3.72s (± 0.40%) 3.72s (± 0.26%) ~ 3.71s 3.73s p=0.673 n=6
Bind Time 1.23s (± 0.80%) 1.18s (± 0.35%) 🟩-0.05s (- 3.80%) 1.18s 1.19s p=0.003 n=6
Check Time 9.52s (± 0.38%) 9.57s (± 0.20%) +0.05s (+ 0.51%) 9.53s 9.58s p=0.018 n=6
Emit Time 8.04s (± 0.36%) 8.06s (± 0.31%) ~ 8.03s 8.09s p=0.414 n=6
Total Time 22.50s (± 0.26%) 22.52s (± 0.15%) ~ 22.47s 22.56s p=0.808 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,514k (± 0.03%) 191,541k (± 0.04%) ~ 191,480k 191,665k p=0.689 n=6
Parse Time 1.56s (± 0.81%) 1.57s (± 0.33%) ~ 1.56s 1.57s p=0.191 n=6
Bind Time 0.84s (± 0.48%) 0.82s (± 0.92%) -0.02s (- 2.77%) 0.81s 0.83s p=0.003 n=6
Check Time 10.08s (± 0.70%) 10.18s (± 0.30%) +0.10s (+ 0.99%) 10.15s 10.22s p=0.037 n=6
Emit Time 3.05s (± 0.81%) 3.06s (± 1.09%) ~ 3.01s 3.11s p=0.572 n=6
Total Time 15.53s (± 0.54%) 15.63s (± 0.28%) +0.09s (+ 0.59%) 15.59s 15.71s p=0.045 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,338k (± 0.01%) 343,267k (± 0.01%) -71k (- 0.02%) 343,245k 343,309k p=0.005 n=6
Parse Time 2.79s (± 0.66%) 2.80s (± 0.60%) ~ 2.78s 2.82s p=0.216 n=6
Bind Time 1.11s (± 1.05%) 1.08s (± 0.38%) -0.03s (- 2.70%) 1.08s 1.09s p=0.004 n=6
Check Time 7.79s (± 0.55%) 7.80s (± 0.71%) ~ 7.72s 7.85s p=0.809 n=6
Emit Time 4.50s (± 0.70%) 4.52s (± 0.95%) ~ 4.47s 4.59s p=0.521 n=6
Total Time 16.19s (± 0.34%) 16.21s (± 0.63%) ~ 16.06s 16.34s p=0.687 n=6
TFS - node (v16.17.1, x64)
Memory used 299,415k (± 0.01%) 299,363k (± 0.01%) -52k (- 0.02%) 299,334k 299,382k p=0.005 n=6
Parse Time 2.19s (± 0.56%) 2.19s (± 0.76%) ~ 2.17s 2.22s p=0.863 n=6
Bind Time 1.26s (± 0.41%) 1.24s (± 0.98%) -0.01s (- 0.93%) 1.22s 1.25s p=0.022 n=6
Check Time 7.22s (± 0.19%) 7.23s (± 0.55%) ~ 7.17s 7.28s p=0.567 n=6
Emit Time 4.25s (± 0.88%) 4.22s (± 0.36%) ~ 4.21s 4.25s p=0.293 n=6
Total Time 14.91s (± 0.35%) 14.89s (± 0.44%) ~ 14.79s 14.99s p=0.630 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,737k (± 0.01%) 475,605k (± 0.00%) -132k (- 0.03%) 475,580k 475,637k p=0.005 n=6
Parse Time 3.32s (± 0.44%) 3.34s (± 0.46%) ~ 3.32s 3.36s p=0.102 n=6
Bind Time 1.02s (± 0.40%) 0.97s (± 0.53%) 🟩-0.05s (- 5.38%) 0.96s 0.97s p=0.003 n=6
Check Time 18.21s (± 0.31%) 18.26s (± 0.84%) ~ 18.10s 18.48s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.55s (± 0.24%) 22.57s (± 0.74%) ~ 22.40s 22.81s p=0.520 n=6
xstate - node (v16.17.1, x64)
Memory used 546,144k (± 0.02%) 546,041k (± 0.02%) ~ 545,913k 546,191k p=0.128 n=6
Parse Time 4.25s (± 0.32%) 4.25s (± 0.23%) ~ 4.24s 4.27s p=1.000 n=6
Bind Time 1.81s (± 0.54%) 1.75s (± 0.51%) 🟩-0.06s (- 3.40%) 1.74s 1.76s p=0.004 n=6
Check Time 3.08s (± 0.81%) 3.05s (± 0.64%) -0.03s (- 0.98%) 3.03s 3.08s p=0.042 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 4.45%) ~ 0.09s 0.10s p=0.405 n=6
Total Time 9.23s (± 0.16%) 9.14s (± 0.20%) -0.09s (- 0.99%) 9.12s 9.17s p=0.005 n=6
Angular - node (v14.15.1, x64)
Memory used 352,568k (± 0.00%) 352,558k (± 0.00%) ~ 352,535k 352,579k p=0.173 n=6
Parse Time 3.71s (± 0.46%) 3.72s (± 0.53%) ~ 3.70s 3.74s p=1.000 n=6
Bind Time 1.29s (± 0.82%) 1.25s (± 0.41%) -0.04s (- 2.98%) 1.24s 1.25s p=0.004 n=6
Check Time 9.87s (± 0.30%) 9.89s (± 0.41%) ~ 9.83s 9.94s p=0.467 n=6
Emit Time 8.34s (± 0.74%) 8.40s (± 1.22%) ~ 8.31s 8.56s p=0.370 n=6
Total Time 23.21s (± 0.24%) 23.25s (± 0.50%) ~ 23.15s 23.42s p=1.000 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,656k (± 0.01%) 186,640k (± 0.01%) ~ 186,618k 186,679k p=0.336 n=6
Parse Time 1.57s (± 0.57%) 1.59s (± 0.87%) ~ 1.57s 1.61s p=0.054 n=6
Bind Time 0.85s (± 0.98%) 0.84s (± 1.22%) ~ 0.83s 0.86s p=0.065 n=6
Check Time 10.24s (± 0.70%) 10.29s (± 0.44%) ~ 10.23s 10.35s p=0.228 n=6
Emit Time 3.14s (± 0.91%) 3.20s (± 0.70%) +0.06s (+ 1.75%) 3.17s 3.22s p=0.012 n=6
Total Time 15.81s (± 0.51%) 15.92s (± 0.34%) +0.10s (+ 0.65%) 15.85s 15.99s p=0.037 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,189k (± 0.01%) 338,144k (± 0.00%) -44k (- 0.01%) 338,136k 338,153k p=0.005 n=6
Parse Time 2.89s (± 0.60%) 2.90s (± 0.42%) ~ 2.89s 2.92s p=0.282 n=6
Bind Time 1.12s (± 0.73%) 1.09s (± 0.76%) -0.02s (- 1.94%) 1.09s 1.11s p=0.008 n=6
Check Time 8.10s (± 0.42%) 8.12s (± 0.41%) ~ 8.07s 8.15s p=0.170 n=6
Emit Time 4.75s (± 0.26%) 4.78s (± 0.71%) ~ 4.75s 4.84s p=0.182 n=6
Total Time 16.86s (± 0.14%) 16.89s (± 0.35%) ~ 16.82s 16.95s p=0.294 n=6
TFS - node (v14.15.1, x64)
Memory used 294,352k (± 0.01%) 294,311k (± 0.00%) -40k (- 0.01%) 294,296k 294,327k p=0.005 n=6
Parse Time 2.40s (± 0.90%) 2.38s (± 0.38%) ~ 2.37s 2.39s p=0.219 n=6
Bind Time 1.10s (± 1.21%) 1.07s (± 1.14%) -0.03s (- 2.42%) 1.06s 1.09s p=0.015 n=6
Check Time 7.55s (± 0.52%) 7.56s (± 0.32%) ~ 7.54s 7.60s p=0.685 n=6
Emit Time 4.61s (± 0.62%) 4.63s (± 1.25%) ~ 4.56s 4.71s p=0.573 n=6
Total Time 15.65s (± 0.37%) 15.64s (± 0.41%) ~ 15.58s 15.75s p=1.000 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,231k (± 0.01%) 471,199k (± 0.01%) -32k (- 0.01%) 471,157k 471,234k p=0.030 n=6
Parse Time 3.49s (± 0.22%) 3.51s (± 0.54%) ~ 3.49s 3.53s p=0.111 n=6
Bind Time 1.04s (± 0.53%) 1.00s (± 0.83%) -0.03s (- 2.90%) 1.00s 1.02s p=0.004 n=6
Check Time 19.09s (± 0.19%) 19.25s (± 0.54%) +0.16s (+ 0.84%) 19.12s 19.39s p=0.010 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.61s (± 0.15%) 23.76s (± 0.42%) +0.15s (+ 0.63%) 23.62s 23.88s p=0.015 n=6
xstate - node (v14.15.1, x64)
Memory used 534,499k (± 0.00%) 534,407k (± 0.00%) -92k (- 0.02%) 534,378k 534,444k p=0.005 n=6
Parse Time 4.58s (± 0.43%) 4.58s (± 0.49%) ~ 4.56s 4.62s p=0.459 n=6
Bind Time 1.72s (± 0.30%) 1.67s (± 0.54%) -0.05s (- 2.72%) 1.66s 1.68s p=0.004 n=6
Check Time 3.16s (± 0.48%) 3.16s (± 0.53%) ~ 3.13s 3.17s p=0.931 n=6
Emit Time 0.10s (± 0.00%) 0.11s (± 3.76%) +0.01s (+ 8.33%) 0.10s 0.11s p=0.007 n=6
Total Time 9.57s (± 0.09%) 9.53s (± 0.34%) -0.05s (- 0.49%) 9.49s 9.58s p=0.034 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52903 6
Baseline main 6

TSServer

Comparison Report - main..52903
Metric main 52903 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,373ms (± 0.31%) 2,367ms (± 0.44%) ~ 2,354ms 2,377ms p=0.422 n=6
Req 2 - geterr 5,372ms (± 0.81%) 5,371ms (± 0.40%) ~ 5,340ms 5,397ms p=0.936 n=6
Req 3 - references 341ms (± 1.12%) 337ms (± 0.40%) -4ms (- 1.12%) 336ms 339ms p=0.037 n=6
Req 4 - navto 282ms (± 0.82%) 285ms (± 0.72%) ~ 281ms 287ms p=0.076 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 72ms (± 1.44%) 71ms (± 0.57%) ~ 71ms 72ms p=0.257 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,491ms (± 0.68%) 2,458ms (± 1.02%) -33ms (- 1.32%) 2,433ms 2,502ms p=0.030 n=6
Req 2 - geterr 4,044ms (± 0.81%) 4,045ms (± 0.61%) ~ 4,015ms 4,085ms p=0.936 n=6
Req 3 - references 353ms (± 0.50%) 352ms (± 0.53%) ~ 350ms 354ms p=0.370 n=6
Req 4 - navto 288ms (± 0.36%) 291ms (± 0.51%) +4ms (+ 1.28%) 290ms 294ms p=0.005 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 71ms (± 9.43%) 67ms (± 1.12%) ~ 66ms 68ms p=0.150 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,189ms (± 0.90%) 3,165ms (± 0.83%) ~ 3,131ms 3,210ms p=0.065 n=6
Req 2 - geterr 1,645ms (± 0.93%) 1,635ms (± 0.98%) ~ 1,619ms 1,657ms p=0.336 n=6
Req 3 - references 104ms (± 1.78%) 104ms (± 1.56%) ~ 102ms 106ms p=1.000 n=6
Req 4 - navto 356ms (± 0.66%) 358ms (± 0.83%) ~ 354ms 361ms p=0.168 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 427ms (± 1.32%) 427ms (± 1.24%) ~ 420ms 432ms p=0.872 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,525ms (± 0.80%) 2,535ms (± 0.77%) ~ 2,506ms 2,563ms p=0.297 n=6
Req 2 - geterr 5,755ms (± 0.40%) 5,757ms (± 0.44%) ~ 5,727ms 5,791ms p=0.936 n=6
Req 3 - references 351ms (± 0.58%) 351ms (± 1.14%) ~ 346ms 357ms p=1.000 n=6
Req 4 - navto 280ms (± 0.35%) 278ms (± 0.95%) ~ 274ms 282ms p=0.155 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 1.06%) 83ms (± 4.06%) ~ 77ms 87ms p=1.000 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,695ms (± 0.69%) 2,657ms (± 0.58%) -38ms (- 1.41%) 2,637ms 2,677ms p=0.006 n=6
Req 2 - geterr 4,362ms (± 0.25%) 4,403ms (± 0.48%) +42ms (+ 0.95%) 4,378ms 4,436ms p=0.008 n=6
Req 3 - references 366ms (± 0.51%) 365ms (± 1.11%) ~ 360ms 370ms p=0.936 n=6
Req 4 - navto 281ms (± 0.42%) 289ms (± 1.37%) +8ms (+ 2.85%) 282ms 293ms p=0.008 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 74ms (± 0.85%) 73ms (± 0.71%) -1ms (- 1.80%) 72ms 73ms p=0.009 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,362ms (± 0.26%) 3,329ms (± 0.59%) -33ms (- 0.99%) 3,298ms 3,357ms p=0.013 n=6
Req 2 - geterr 1,873ms (± 4.29%) 1,851ms (± 3.67%) ~ 1,806ms 1,986ms p=0.748 n=6
Req 3 - references 112ms (± 1.56%) 112ms (± 2.51%) ~ 109ms 116ms p=0.571 n=6
Req 4 - navto 344ms (± 1.38%) 347ms (± 1.73%) ~ 339ms 353ms p=0.169 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 434ms (± 1.35%) 435ms (± 0.83%) ~ 431ms 441ms p=0.872 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,608ms (± 1.08%) 2,571ms (± 0.39%) -36ms (- 1.39%) 2,554ms 2,584ms p=0.045 n=6
Req 2 - geterr 6,099ms (± 1.02%) 6,090ms (± 0.13%) ~ 6,076ms 6,100ms p=1.000 n=6
Req 3 - references 366ms (± 1.03%) 365ms (± 0.40%) ~ 363ms 367ms p=0.806 n=6
Req 4 - navto 277ms (± 0.90%) 279ms (± 1.52%) ~ 276ms 287ms p=0.622 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 101ms (± 1.32%) 100ms (± 2.10%) ~ 96ms 102ms p=0.676 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,827ms (± 0.60%) 2,805ms (± 0.44%) -21ms (- 0.75%) 2,788ms 2,815ms p=0.030 n=6
Req 2 - geterr 4,625ms (± 2.25%) 4,520ms (± 1.93%) ~ 4,465ms 4,697ms p=0.148 n=6
Req 3 - references 380ms (± 0.55%) 387ms (± 4.96%) ~ 379ms 426ms p=1.000 n=6
Req 4 - navto 293ms (± 1.25%) 294ms (± 1.30%) ~ 287ms 297ms p=0.872 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 85ms (± 9.64%) 89ms (± 9.39%) ~ 81ms 102ms p=0.254 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,680ms (± 0.38%) 3,668ms (± 0.47%) ~ 3,645ms 3,697ms p=0.295 n=6
Req 2 - geterr 1,866ms (± 1.98%) 1,862ms (± 1.80%) ~ 1,827ms 1,895ms p=1.000 n=6
Req 3 - references 127ms (± 3.05%) 126ms (± 2.38%) ~ 123ms 130ms p=0.935 n=6
Req 4 - navto 372ms (± 1.47%) 372ms (± 1.48%) ~ 365ms 379ms p=0.936 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 450ms (± 1.72%) 449ms (± 1.41%) ~ 440ms 456ms p=0.936 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52903 6
Baseline main 6

Startup

Comparison Report - main..52903
Metric main 52903 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.28ms (± 0.20%) 142.34ms (± 0.20%) +0.05ms (+ 0.04%) 141.70ms 146.50ms p=0.002 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.67ms (± 0.18%) 226.72ms (± 0.16%) +0.04ms (+ 0.02%) 225.64ms 232.93ms p=0.007 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.46ms (± 0.18%) 228.59ms (± 0.16%) +0.13ms (+ 0.06%) 227.52ms 233.34ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.32ms (± 0.18%) 209.47ms (± 0.17%) +0.15ms (+ 0.07%) 208.55ms 213.71ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52903 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

wowee

DanielRosenwasser
DanielRosenwasser reviewed Feb 22, 2023
View reviewed changes
src/compiler/binder.ts
var unreachableFlow: FlowNode = { flags: FlowFlags.Unreachable };
var reportedUnreachableFlow: FlowNode = { flags: FlowFlags.Unreachable };
var bindBinaryExpressionFlow = createBindBinaryExpressionFlow();
/* eslint-enable no-var */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one thing I was thinking with these - we should really move the return statement immediately closer to these so that it is clear that this is where shared state resides.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea; I think the checker already does this. Let me do that and rerun perf.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JK, it's right there, two functions down.

@DanielRosenwasser
Copy link
Member

:shipit:

@jakebailey jakebailey merged commit c5e4f00 into microsoft:main Feb 22, 2023
@jakebailey jakebailey deleted the let-const-binder branch February 22, 2023 01:32
@DanielRosenwasser DanielRosenwasser mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @DanielRosenwasser