Skip to content

Properly re-scan > token in type argument list determination logic #49560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2022
Merged

Properly re-scan > token in type argument list determination logic #49560

merged 2 commits into from
Jun 15, 2022

Conversation

ahejlsberg
Copy link
Member

Fixes #49551.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 15, 2022
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 15, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f1f6af8. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 15, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f1f6af8. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 15, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f1f6af8. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@ahejlsberg
Great news! no new errors were found between main..refs/pull/49560/merge

@DanielRosenwasser
Copy link
Member

Should we cherry-pick this? Feels bad to have in 4.7.

@typescript-bot
Copy link
Collaborator

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@ahejlsberg
Copy link
Member Author

Should we cherry-pick this? Feels bad to have in 4.7.

Yeah, I'd be in favor of cherry-picking.

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 15, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.7 on this PR at f1f6af8. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.7 manually.

@andrewbranch andrewbranch added this to the TypeScript 4.7.4 milestone Jun 15, 2022
@ahejlsberg ahejlsberg merged commit 18ac372 into main Jun 15, 2022
@ahejlsberg ahejlsberg deleted the fix49551 branch June 15, 2022 19:06
DanielRosenwasser added a commit that referenced this pull request Jun 15, 2022
@DanielRosenwasser
Properly re-scan > token in type argument list determination logic (#…
67058d9 
…49560)

* Properly re-scan '>' token in type argument list determination logic

* Add regression test
@DanielRosenwasser DanielRosenwasser mentioned this pull request Jun 15, 2022
Merged
DanielRosenwasser added a commit that referenced this pull request Jun 16, 2022
@DanielRosenwasser
Properly re-scan > token in type argument list determination logic (#…
dfe885b 
…49560) (#49570)

* Properly re-scan '>' token in type argument list determination logic

* Add regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
TypeScript 4.7.4
Development

Successfully merging this pull request may close these issues.

Unexpected syntax errors of a < (b >= c ...) in TS 4.7
5 participants
@ahejlsberg @typescript-bot @DanielRosenwasser @RyanCavanaugh @andrewbranch