Compute writeType from set accessors for union and intersection properties #47674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
Jan 31, 2022
weswigham
approved these changes
Feb 8, 2022
RyanCavanaugh
approved these changes
Feb 8, 2022
whzx5byb
reviewed
Aug 2, 2022
| if (!links.writeType && links.deferralWriteConstituents) { | ||
| Debug.assertIsDefined(links.deferralParent); | ||
| Debug.assertIsDefined(links.deferralConstituents); | ||
| links.writeType = links.deferralParent.flags & TypeFlags.Union ? getUnionType(links.deferralWriteConstituents) : getIntersectionType(links.deferralWriteConstituents); |
There was a problem hiding this comment.
Shouldn't the write type of a union be resolved into an intersection type? Just like the way mentioned in #30769
There was a problem hiding this comment.
If you come up with a code example that doesn’t work the way you expect, feel free to file an issue.
There was a problem hiding this comment.
If you come up with a code example that doesn’t work the way you expect, feel free to file an issue.
Please have a look at the unsound behavior described in #50142. A comment indicates that it should be treated using the same rule of #30769.
I'm not quite sure but I guess it could have relation to this PR, where the write type of a union is not resolved into an intersection, but a union.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45376