Skip to content

Declare non-const enums if preserveConstEnums is true #46626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Declare non-const enums if preserveConstEnums is true #46626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9405a03
Declare non-const enums if isolatedModules is true
jablko Nov 1, 2021
42d1408
Move from emitter -> transformer
jablko Nov 4, 2021
b4dc52b
Broaden from isolatedModules -> preserveConstEnums
jablko Nov 4, 2021
04f4bc4
Inline plain enums from referenced projects
jablko Mar 2, 2022
ee3537f
Ignore ambient const enums
jablko Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/compiler/emitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ namespace ts {
target: compilerOptions.target,
sourceMap: compilerOptions.sourceMap,
inlineSourceMap: compilerOptions.inlineSourceMap,
isolatedModules: compilerOptions.isolatedModules,
extendedDiagnostics: compilerOptions.extendedDiagnostics,
onlyPrintJsDocStyle: true,
writeBundleFileInfo: !!bundleBuildInfo,
Expand Down Expand Up @@ -3261,7 +3262,17 @@ namespace ts {
}

function emitEnumDeclaration(node: EnumDeclaration) {
emitModifiers(node, node.modifiers);
// Elide const modifiers if isolatedModules is true
emitModifiers(
node,
factory.createNodeArray(
filter(
node.modifiers,
modifier => !printerOptions.isolatedModules || modifier.kind !== SyntaxKind.ConstKeyword
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively this could be done when parsing vs. emitting const enums?

),
node.modifiers?.hasTrailingComma
)
);
writeKeyword("enum");
writeSpace();
emit(node.name);
Expand Down
1 change: 1 addition & 0 deletions src/compiler/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8211,6 +8211,7 @@ namespace ts {
/*@internal*/ sourceMap?: boolean;
/*@internal*/ inlineSourceMap?: boolean;
/*@internal*/ inlineSources?: boolean;
/*@internal*/ isolatedModules?: boolean;
/*@internal*/ extendedDiagnostics?: boolean;
/*@internal*/ onlyPrintJsDocStyle?: boolean;
/*@internal*/ neverAsciiEscape?: boolean;
Expand Down