Use other files when necessary to determine import style in JS #40879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
sheetalkamat
approved these changes
Oct 1, 2020
sandersn
approved these changes
Oct 5, 2020
| if (otherFile.externalModuleIndicator && !otherFile.commonJsModuleIndicator) return false; | ||
| } | ||
|
|
||
| // 5. Literally nothing to go on |
There was a problem hiding this comment.
Suggested change
| // 5. Literally nothing to go on | |
| // 5. Literally nothing to go on, why not zoidberg? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29038 (even more)