Relax switch-case narrowing restrictions #23522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compiler/checker.ts
Outdated
| return !!getPropertyOfType(type, "0" as __String); | ||
| } | ||
|
|
||
| function isNotUnitTypeOrNever(type: Type): boolean { |
There was a problem hiding this comment.
Nit: isNeitherUnitTypeNorNever
There was a problem hiding this comment.
But I don't use the neither/nor operator in the body. 👅
ahejlsberg
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23510
Switch-case exhaustiveness is still handled roughly the same way, however this removes the unit type restriction on switch-case narrowing (which brings it inline with
ifnarrowing).