<chrono>: Use designated aggregate initialization when returning tm
#5662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
designated-tm
branch
from
2898e24 to
da6e4cf
Compare
frederick-vs-ja
force-pushed
the
designated-tm
branch
from
da6e4cf to
fbb9541
Compare
jovibor
reviewed
Aug 1, 2025
StephanTLavavej
requested changes
Aug 2, 2025
github-project-automation
bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
StephanTLavavej
approved these changes
Aug 2, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
😸 ⏱️ 📆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one place in the whole MSVC STL where
tmis returned by value. Currently, thetm_isdstmember of the variable to return is uninitialized, so it can be sometimes technically UB/EB to return such an object, unless NRVO is done.I think it's arguably better and clearer to just return a prvalue using designated aggregate initialization,
which zero-initializes the. Note that currently it's only mentioned in a comment among the whole STL.tm_isdstmember without mentioning itEdit: Clang doesn't like such implicit zero-initialization. Sigh.