Restore wmemchr optimization in ranges::find
#5628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
force-pushed
the
wmemchr
branch
2 times, most recently
from
dc28407 to
c03a3ed
Compare
|
This is restoring it for sized calls only, which seems safe. The problem was with unsized. |
StephanTLavavej
approved these changes
Jul 10, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for getting us to the right place here! 🎯 🚀 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ranges::findis not usingwmemchrafter #5284. Yet,std::finduses it.For
wmemchrwe drag in<cwchar>which is heavy, specifically due towmemchroptimization. So it seems silly not to take the full advantage ofwmemchr. The PR addresses that by makingranges::findalso usingwmemchr.This affects ARM64 (non-EC), and builds with vector algorithms disabled.
See also #5596. Not sure if this PR closes that issue, because merging the PR does not preclude doing also Windows SDK throughput optimization or otherwise addressing the throughput in the future.