Skip to content

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jun 9, 2025

Addresses #5567 (comment) for which I filed LWG-4273. IIUC we can make the changes even without corresponding changes in the standard wording.

The test suite is reworked to cover tag class types more specifically. I'm trying to cover implementation-internal construction tag types together, although the list seems messy and it might be better to make some cleanup later.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner June 9, 2025 07:18
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jun 9, 2025
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jun 9, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jun 9, 2025
@StephanTLavavej
Copy link
Member

Thanks! I pushed extremely minor nitpicks and verified that the test is currently exhaustive.

@StephanTLavavej StephanTLavavej removed their assignment Aug 7, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Aug 7, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Aug 7, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 96f154a into microsoft:main Aug 8, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Aug 8, 2025
@StephanTLavavej
Copy link
Member

Tag, you're it! 😹 🎉 🤪

@frederick-vs-ja frederick-vs-ja deleted the lwg-4273 branch August 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants