Skip to content

Conversation

vinay-852
Copy link
Contributor

@vinay-852 vinay-852 commented May 2, 2025

This PR updates the _MSVC_STL_VERSION macro in yvals_core.h from 143 to 145 to reflect the beginning of work on Visual Studio 18, whose toolset will identify itself as "v145".

Updated line:
#define _MSVC_STL_VERSION 143#define _MSVC_STL_VERSION 145

#define _MSVC_STL_UPDATE 202504L#define _MSVC_STL_UPDATE 202505L

This change ensures consistency with the new toolset versioning and aligns with the guidelines mentioned in issue #5461.

Closes #5461 .

@vinay-852 vinay-852 requested a review from a team as a code owner May 2, 2025 11:20
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 2, 2025
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label May 2, 2025
@StephanTLavavej
Copy link
Member

Thanks! There's a typo in your PR description - it says it's changing _MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)

We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews May 2, 2025
@vinay-852
Copy link
Contributor Author

Thanks! There's a typo in your PR description - it says it's changing _MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)

We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

Thanks for the clarification, Stephan! I’ll update the description and keep your suggestions in mind for future PRs.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews May 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request May 9, 2025
@StephanTLavavej StephanTLavavej changed the title Update _MSVC_STL_VERSION from 143 to 145 for Visual Studio 18 toolset Update _MSVC_STL_UPDATE to May 2025 and update _MSVC_STL_VERSION to 145 May 9, 2025
@StephanTLavavej StephanTLavavej merged commit 3a06698 into microsoft:main May 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews May 10, 2025
@StephanTLavavej
Copy link
Member

Thanks for updating these version macros and congratulations on your first microsoft/STL commit! 🎉 😻 🐈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to May 2025 and update _MSVC_STL_VERSION to 145
2 participants