Skip to content

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 2, 2025

clang-cl will produce

std::chrono::time_point<std::chrono::system_clock,std::chrono::duration<long long,std::ratio<1,10000000>>>

as the type name for std::chrono::system_clock::time_point whereas MSVC will produce

std::chrono::time_point<std::chrono::system_clock,std::chrono::duration<__int64,std::ratio<1,10000000>>>

Notice: long long vs __int64 (llvm/llvm-project#134156).

As a workaround, I added the type from clang-cl as an <AlternativeType>.

@Nerixyz Nerixyz requested a review from a team as a code owner April 2, 2025 21:11
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Apr 2, 2025
@StephanTLavavej StephanTLavavej added enhancement Something can be improved visualizer How the VS debugger displays STL types labels Apr 2, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Apr 2, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 9, 2025
@StephanTLavavej StephanTLavavej self-assigned this Apr 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5762e6b into microsoft:main Apr 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 10, 2025
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Apr 10, 2025

Thanks for helping to support Clang as a first-class citizen! 🎉 🐱 🐈

I triple-mirrored this change to VS so it will take effect, internal VS-PR-627142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved visualizer How the VS debugger displays STL types
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants