Implement P0472R3 - Put monostate in <utility>
#5382
Merged
+41
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
StephanTLavavej
approved these changes
Mar 31, 2025
|
Thanks! I pushed an additional commit to follow our convention of listing all implemented features in This change is sufficiently simple and resistant to accidental damage that no test coverage is necessary. We merge PRs simultaneously to our GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, likely either this week or next week. I'll post comments here as I prepare your PR for merging! |
StephanTLavavej
approved these changes
Apr 1, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this C++26 feature, and congratulations on your first microsoft/STL commit! 😻 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
monostate(from<xutility>) and related definitions (from<variant>) to<utility>.<utility>is included by both headers, so no code is broken.resolves #5294