Skip to content

Prepare ranges test for MSVC fix #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Prepare ranges test for MSVC fix #5378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/std/tests/P0896R4_ranges_iterator_machinery/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,7 +1076,11 @@ namespace iterator_cust_move_test {
#if defined(__clang__) || defined(__EDG__) // TRANSITION, VSO-1008447
static_assert(same_as<iter_rvalue_reference_t<int(int)>, int (&)(int)>);
#else // ^^^ no workaround / workaround vvv
#ifdef _MSVC_INTERNAL_TESTING // TRANSITION, assertion will fire once VSO-2066340 ships.
static_assert(same_as<iter_rvalue_reference_t<int(int)>, int (&&)(int)>);
#else // ^^^ defined(_MSVC_INTERNAL_TESTING) / !defined(_MSVC_INTERNAL_TESTING) vvv
static_assert(same_as<iter_rvalue_reference_t<int(int)>, int (*)(int)>);
#endif // ^^^ !defined(_MSVC_INTERNAL_TESTING)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change requested: This comment is missing ^^^ at the end but it's fine, I'll be removing this preprocessor logic pretty soon anyways.

#endif // ^^^ workaround ^^^

static_assert(same_as<iter_rvalue_reference_t<int[4]>, int&&>);
Expand Down