-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Use find
for search_n
when n=1
#5346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+122
β0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the detailed PR description and significant optimization! π I pushed very minor nitpicks to the benchmark. |
StephanTLavavej
approved these changes
Mar 20, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2025
Thanks for finding this optimization opportunity! πΉ π΅οΈ π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π The optimization
There are two implementations of
search_n
β instd
and instd::ranges
. For bidirectional iterators, both implementations take advantage of the contiguous range to search for. They jump forward by the value of n and try to match from the end. This allows skipping some comparisons. When there are more mismatches than matches, it ends up in fast pass over the range and few comparisons.This means than for large values of n and non-pathological input, the algorithm is not even likely to benefit from vectorization.
For small values of n, however, the algorithm performs worse.
The worst case is n=1, where the algortihm is just
find
with extra steps. The PR forwards this case directly tofind
, where it may pick the vectorization ormemchr
, and even if it doesn't, it would still stop looking into doing extra steps.βοΈ Predicate check
Unlike many other algorithms, such as
find
, thesearch_n
algorithm takes both value and predicate. We want to forward to predicate-lessfind
, as we're trying to engage vectorization, so we can do this when seeing the defaultequal_to
predicate. Binding the value and the predicate into a bigger predicate and passing that tofind_if
would work for more cases, but would not be (manually) vectorized.Since the value type and iterator type are unrelated, the comparison is potentially heterogenous, so it is hard to verify if non-
void
specialization ofstd::equal_to<T>
does the same as default comparison, or not. We'll skip that, and check just forstd::equal_to<void>
andranges::equal_to
.β Test coverage
There's no attempt of comprehensive coverage of
std::search_n
π. Just some ad-hoc tests, mostly negative. Creating one seems out of scope for this PR. The n=1 case seems to be covered indirectly viaP0024R2_parallel_algorithms_search_n
test, along with many other cases.For
ranges::search_n
there's a pre-existing test that does at least some minimum coverage, expanded that with n=1 case.β±οΈBenchmark results