-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve debug checks (prelude to STL Hardening) #5270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 35 commits into
microsoft:main
from
StephanTLavavej:prelude-to-foundation
Feb 11, 2025
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
0962eb1
Remove CDL preprocessor comments after a single line.
StephanTLavavej acc4f34
Remove CDL preprocessor comments after a single `_STL_VERIFY` over mu…
StephanTLavavej c20b369
docs/import_library.md: Don't mention CDL - it doesn't affect ABI, an…
StephanTLavavej 2cb3a35
Improve debug messages: "array<T, 0> subscript invalid"
StephanTLavavej 06a1361
Improve debug messages: "MEOW subscript out of range"
StephanTLavavej 97d2acb
Improve debug messages: "MEOW() called on empty WOOF"
StephanTLavavej a7ce525
Improve debug messages: Clarify span's first<Count>(), last<Count>(),…
StephanTLavavej f325132
Improve debug messages: Clarify string_view remove_prefix(), remove_s…
StephanTLavavej a3de284
Improve debug messages: std::expected.
StephanTLavavej a5ab1f5
Improve debug messages: Grammar.
StephanTLavavej eca9c57
Test cleanup: Remove CDL definitions from some `<ranges>` tests.
StephanTLavavej fd0c6f1
Test cleanup: Drop CDL from `<format>` test, properly test negative d…
StephanTLavavej 2007c12
Test cleanup: Remove VSO-847348 workarounds.
StephanTLavavej ed90fb1
Test cleanup: Use `if constexpr` instead of tag dispatch and plain `if`.
StephanTLavavej 6554e97
Code cleanups: Add const, unwrap "strengthened".
StephanTLavavej a78ff8d
Code cleanup: Conditional `_STL_REPORT_ERROR` => `_STL_VERIFY` or `_S…
StephanTLavavej 88a59ba
Code cleanup: `_STL_VERIFY(false)` => `_STL_REPORT_ERROR`
StephanTLavavej 71dcd4f
Code cleanup: Consistently order `case` before `default`.
StephanTLavavej 25960e5
Code cleanup: Fuse _Check_alignment into atomic_ref ctor.
StephanTLavavej 85f29dc
Code cleanup: Collapse _ATOMIC_REF_CHECK_ALIGNMENT into _STL_ASSERT.
StephanTLavavej 57e3cca
Code cleanup: Avoid duplicating _Off and _Count. Add const to _Moved.
StephanTLavavej 22a4cbb
Code cleanup: Avoid duplicating _STD copy() call.
StephanTLavavej 59512b9
Code cleanup: Avoid more duplication.
StephanTLavavej 62ce28d
Code cleanup: IDL == 2 implies debug, so _STL_ASSERT should be _STL_V…
StephanTLavavej 8c69d19
Code cleanup: Extract _Can_memcpy for clarity, simplifying following …
StephanTLavavej 451c7ba
Enhancement (for CoE): Adjust uninitialized_meow's logic.
StephanTLavavej 33df586
Enhancement (for CoE): After _INVALID_MEMORY_ORDER, consistently fall…
StephanTLavavej 81776a0
Enhancement: _STL_ASSERT => _STL_VERIFY for checks within IDL >= 1.
StephanTLavavej 0f562b8
Enhancement: Replace _STL_ASSERT with _STL_INTERNAL_STATIC_ASSERT.
StephanTLavavej 925cd6a
Enhancement: Remove IDL=2 null asserts from auto_ptr deref/arrow.
StephanTLavavej a6ea00a
Enhancement: _Span_iterator::operator-= was unconditionally checking.
StephanTLavavej b1f76b8
Enhancement: Improve `_STL_REPORT_ERROR`, `_STL_VERIFY` codegen.
StephanTLavavej 05fdc63
Code cleanup: Use `_Check_MEOW_memory_order` to avoid some `_FALLTHRO…
StephanTLavavej 7f6b11b
Improve debug messages: "stores" => "contains"
StephanTLavavej 5fee29e
Code review feedback: Improve debug messages and whitespace.
StephanTLavavej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.