<format>: Alternate form general floating-point width handling #5261
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@microsoft-github-policy-service agree |
...std/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/env.lst
Outdated
Show resolved
Hide resolved
...std/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/env.lst
Outdated
Show resolved
Hide resolved
...td/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/test.cpp
Outdated
Show resolved
Hide resolved
...td/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/test.cpp
Outdated
Show resolved
Hide resolved
...std/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/env.lst
Outdated
Show resolved
Hide resolved
|
Thank you, looks great! 😻 We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, probably this week but maybe next week depending on how busy I am. (There's plenty of time to get fixes into 17.14 Preview 3.) I'll post comments here as I prepare your PR for merging. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this runtime correctness bug in one of the STL's most popular new headers! 🐞 🛠️ 😻 By the way, it appears that your commits contained two email addresses, only one of which is known to GitHub, which causes your commit to appear to have a coauthor ("alexprabhat99 and alexprabhatbara"). You can fix this by telling GitHub about your alternate email address - I do this with my work and personal emails. Click on your profile avatar in the upper right > Settings > Emails (in the left sidebar), then add your secondary email address. |
Fixes: #5011