Skip to content

Conversation

muellerj2
Copy link
Contributor

Resolves #5204. Follow-up to #5164 and #5209.

When compiled under /MD or /MDd, the new test cases specific to collating ranges are skipped:

Drive-by changes:

  • Mark _Parser::_Error() as [[noreturn]].
  • In _Matcher::_Skip() and _Matcher::_Do_class(), _STD qualify calls to some free functions and clean up the control flow that translates the current character and converts it to an unsigned value.

@muellerj2 muellerj2 requested a review from a team as a code owner January 15, 2025 18:28
@CaseyCarter CaseyCarter added the bug Something isn't working label Jan 15, 2025
@StephanTLavavej StephanTLavavej added the regex meow is a substring of homeowner label Jan 15, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jan 15, 2025
@StephanTLavavej
Copy link
Member

Thanks! This makes sense and looks good to me. The comprehensive test coverage is excellent. 😻

I pushed a trivial merge with main followed by a bunch of nitpicks. The most significant changes were to regex_with_locale_should_throw(), to actually use syntax and to properly record failure when an exception is thrown with an unexpected code.

@StephanTLavavej StephanTLavavej removed their assignment Mar 20, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 20, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Mar 21, 2025
@StephanTLavavej StephanTLavavej self-assigned this Mar 21, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Mar 21, 2025
@StephanTLavavej StephanTLavavej merged commit 92cbb9b into microsoft:main Mar 24, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Mar 24, 2025
@StephanTLavavej
Copy link
Member

Thanks for sorting out this bug! 😹 🐞 🪄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regex meow is a substring of homeowner
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<regex>: Collating ranges are broken
3 participants