Avoid arithmetic overflow in the constructors of weekday
#5156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cassio Neri <[email protected]>
cassioneri
approved these changes
Nov 29, 2024
CaseyCarter
approved these changes
Nov 30, 2024
tests/std/tests/P0355R7_calendars_and_time_zones_dates/test.cpp
Outdated
Show resolved
Hide resolved
Clarify some comments, and add a `static_assert` to catch if the code is ported somewhere for which `unsigned int` isn't 32 bits.
|
I pushed a commit to wiggle some comments and add an |
StephanTLavavej
approved these changes
Dec 1, 2024
cassioneri
approved these changes
Dec 3, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this corner case! 🛠️ 🌋 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5153.