Fix false positives by filesystem::equivalent on file systems with transient file IDs
#5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transient file IDs
muellerj2
commented
Nov 24, 2024
CaseyCarter
added
bug
StephanTLavavej
approved these changes
Dec 2, 2024
|
Thanks, this is awesome! 😻 I pushed cosmetic changes. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for figuring out how to fix this runtime correctness bug! 📄 🟰 📜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3571 for
<filesystem>and<experimental/filesystem>.The fix for
<experimental/filesystem>affects the redist because it changes the implementation of_Equivalentinfilesys.cppthat is exported by msvcp140.dll.There is no additional test coverage because a reliable test for this issue would involve setting up a drive commonly producing such transient file IDs. But I verified manually with a drive shared by Remote Desktop that (a) false positives by
std::filesystem::equivalentandstd::experimental::filesystem::equivalentare present without this PR and (b) are gone with it. I also added comments at the top of_Equivalentand__std_fs_equivalentthat reference #3571 and serve as a reminder why the file handles can't be closed before file IDs for both files have been obtained.