Skip to content

<chrono>: Add comments for compiler bug workarounds #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2024
Merged

<chrono>: Add comments for compiler bug workarounds #4920

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27f4679
Remove pre-P0960R3 workaround for `emplace_front`
frederick-vs-ja Aug 27, 2024
be90910
Remove `tzdb_list::_Emplace_front` and completely hack in test codes
frederick-vs-ja Aug 27, 2024
558d45c
Revert "Remove pre-P0960R3 workaround for `emplace_front`"
frederick-vs-ja Aug 27, 2024
b7baa10
VSO-2228186
frederick-vs-ja Aug 27, 2024
d9851b1
Revert all but the TRANSITION, VSO-2228186 comments.
StephanTLavavej Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stl/inc/chrono
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2209,6 +2209,7 @@ namespace chrono {
auto [_Icu_version, _Zones, _Links] = _Tzdb_generate_time_zones();
auto [_Leap_sec, _All_ls_positive] = _Tzdb_generate_leap_seconds(0);
auto _Version = _Icu_version + "." + _STD to_string(_Leap_sec.size());
// TRANSITION, VSO-2228186, should call emplace_front with construction arguments
_Tzdb_list.emplace_front(tzdb{
_STD move(_Version), _STD move(_Zones), _STD move(_Links), _STD move(_Leap_sec), _All_ls_positive});
}
Expand Down Expand Up @@ -2266,6 +2267,7 @@ namespace chrono {
}

auto _Version = _Tzdb_update_version(_Tzdb.version, _Leap_sec.size());
// TRANSITION, VSO-2228186, should call emplace_front with construction arguments
_Tzdb_list.emplace_front(tzdb{
_STD move(_Version), _STD move(_Zones), _STD move(_Links), _STD move(_Leap_sec), _All_ls_positive});
}
Expand Down