Implement LWG-4061 Should std::basic_format_context be default-constructible/copyable/movable?
#4758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
commented
Jun 30, 2024
| @@ -168,6 +168,9 @@ std/utilities/memory/specialized.algorithms/uninitialized.move/ranges_uninitiali | |||
| std/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer.value/ctor.default.pass.cpp FAIL | |||
| std/ranges/range.adaptors/range.lazy.split/range.lazy.split.outer.value/ctor.iter.pass.cpp FAIL | |||
|
|
|||
| # libc++ doesn't implement LWG-4061 | |||
| std/utilities/format/format.functions/bug_81590.compile.pass.cpp FAIL | |||
There was a problem hiding this comment.
This test is weird. It has a formatter specialization whose format function passes basic_format_context by value, which is unexpected.
13 tasks
StephanTLavavej
approved these changes
Jul 3, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this LWG issue resolution! Resolve all the things! 🪄 🎉 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See LWG-4061 and WG21-P3341R0.
Blocked libcxx test
std/utilities/format/format.functions/bug_81590.compile.pass.cpp