Implement P0952R2: 'A new specification for std::generate_canonical'
#4740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattStephanson
commented
Jun 20, 2024
MattStephanson
commented
Jun 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
changed the title
std::generate_canonical"std::generate_canonical'
This comment was marked as resolved.
This comment was marked as resolved.
…inbits <= 64`. `_Bits` was totally bogus (being 2^32 - 1 or 2^64 - 1) so `_Minbits` was always `_Digits`. Let's update all usage to `_Digits` for clarity, since there's no "min" happening anymore. `_Minbits <= 64` was always true, so drop it.
StephanTLavavej
approved these changes
Jun 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit c658217.
StephanTLavavej
approved these changes
Jun 27, 2024
|
Thanks for implementing this major overhaul of central |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074. Fixes #4169.