Implement range-default-formatter
#4716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
2 times, most recently
from
af2c18c to
a86faaf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
from
a86faaf to
065f92c
Compare
|
There are a lot of code movements. To make code review easier, can you split them into a separate commit? |
The following tests are derived from libc++'s test files: - `P2286R8_text_formatting_range_map` - `P2286R8_text_formatting_range_sequence` - `P2286R8_text_formatting_range_set` - `P2286R8_text_formatting_range_string` Note that libc++'s `range_formatter` is currently buggy on the `m` option, see LLVM-90196 and LLVM-94562. The test `P2286R8_text_formatting_tuple_disambiguation` covers formatting `pair`s and `tuple`s that are also ranges. Unblocks libcxx tests: - `std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.format.pass.cpp` - `std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.vformat.pass.cpp` - `std/utilities/format/format.range/format.range.fmtdef/parse.pass.cpp` - `std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp` - `std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp` - `std/utilities/format/format.range/format.range.fmtmap/parse.pass.cpp` - `std/utilities/format/format.range/format.range.fmtset/parse.pass.cpp` - `std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp` - `std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp` - `std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp` - `std/input.output/iostream.format/print.fun/includes.compile.pass.cpp`
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
from
065f92c to
e0b8a30
Compare
Done. |
cpplearner
reviewed
Jun 9, 2024
Removing one improper `// exposition only` comment. Co-authored-by: S. B. Tam <[email protected]>
StephanTLavavej
added
ranges
tests/std/tests/P2286R8_text_formatting_tuple_disambiguation/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jun 25, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this next step towards completing C++23! 🎉 😻 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2919/WG21-P2286R8/WG21-P2585R1.
The following tests are derived from libc++'s test files:
P2286R8_text_formatting_range_mapP2286R8_text_formatting_range_sequenceP2286R8_text_formatting_range_setP2286R8_text_formatting_range_stringNote that libc++'s
range_formatteris currently buggy on themoption, see LLVM-90196 and LLVM-94562.The test
P2286R8_text_formatting_tuple_disambiguationcovers formattingpairs andtuples that are also ranges.Unblocks libcxx tests:
std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.format.pass.cppstd/containers/sequences/vector.bool/vector.bool.fmt/format.functions.vformat.pass.cppstd/utilities/format/format.range/format.range.fmtdef/parse.pass.cppstd/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cppstd/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cppstd/utilities/format/format.range/format.range.fmtmap/parse.pass.cppstd/utilities/format/format.range/format.range.fmtset/parse.pass.cppstd/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cppstd/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cppstd/utilities/format/format.range/format.range.fmtstr/parse.pass.cppstd/input.output/iostream.format/print.fun/includes.compile.pass.cpp