<format>: Fix handling of replacement field when format-spec is absent
#4640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
And fix some `parse` functions in the test.
frederick-vs-ja
commented
Apr 29, 2024
barcharcraz
reviewed
May 14, 2024
| throw format_error{"only empty specs please"}; | ||
| } | ||
| return parse_ctx.end(); | ||
| return parse_ctx.begin(); |
There was a problem hiding this comment.
This should be non-functional, correct? It's a matter of if we "match" the closing '}' or not.
barcharcraz
approved these changes
May 14, 2024
tests/std/tests/P0645R10_text_formatting_custom_formatting/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 16, 2024
|
Thanks! FYI @barcharcraz I pushed minor changes after you approved. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks! Fewer correctness bugs, happier users! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4636. Also fixes the runtime behavior - both output line in the reported example should be
arg-id: 1, arg-id: 3.I've verified that the example posted in #4078 still fails to compile (when using
/utf-8or awchar_tvariant). But I don't know how to test such error in the test suits of MSVC STL.