<xmemory>: Unify overloads of _Allocate and _Deallocate with if constexpr
#4432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n early `return`.
When `_Bytes == 0`, the branch `_Bytes >= _Big_allocation_threshold` will certainly not be taken, so we can perform this transformation.
This transformation has very minor impact. Sometimes, we'll call `is_constant_evaluated` when we would have returned `_Traits::_Allocate(_Bytes)` anyways. (This happens when we don't take the high-`_Align` branch and we aren't x86/x64.) This is an extremely minor cost, and it completely vanishes in release mode. The code simplicity is well worth it.
StephanTLavavej
approved these changes
Mar 5, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
I've pushed a merge with |
StephanTLavavej
approved these changes
Mar 8, 2024
|
Thanks for this dramatic simplification! All shall love |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both
_Allocateand_Deallocatehave multiple overloads that are dispatched by SFINAE.It seems that we should dispatch overaligned and normal branches with
if constexprinstead (see #189).