<atomic>: ADL-proof implementation of atomic and atomic_ref
#4221
+238
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Jan 12, 2024
|
Thanks! I pushed a conflict-free merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
☢️ 🛡️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #140.
(A little number of
atomic-related changes were already done in #4138.)Notes:
__builtin_zero_non_value_bitsis qualified due to a bug of MSVC (which was originally reported as DevCom-10527599, but soon considered as a duplicate of DevCom-10456452); other intrinsics are not qualified._Atomic_address_asdoesn't need to be qualified in some specializations because the passed argument is always an integer. There's a separated commit making_STD-qualification for_Atomic_address_asconsistent._Check_memory_order,_Check_store_memory_order, and_Check_load_memory_orderare not qualified because the passed argument is always eitherunsigned intormemory_order. I'm not sure whether it would be better to qualify them.