Skip to content

inline internal function that are called only once in vector_algorithms.cpp #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2023
Merged

inline internal function that are called only once in vector_algorithms.cpp #4113

merged 2 commits into from
Oct 25, 2023

Conversation

AlexGuteniev
Copy link
Contributor

Resolves #3963

Also remove some stray newlines @CaseyCarter complained about.
Also drop some superfluous typenames.

Will conflict with #3928 , which I'll have to fix after either is merged.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner October 21, 2023 07:32
@AlexGuteniev AlexGuteniev mentioned this pull request Oct 21, 2023
Merged
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 21, 2023
@StephanTLavavej StephanTLavavej self-assigned this Oct 21, 2023
@StephanTLavavej StephanTLavavej removed their assignment Oct 23, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Oct 24, 2023
Merged
@StephanTLavavej StephanTLavavej self-assigned this Oct 24, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0521c6a into microsoft:main Oct 25, 2023
@StephanTLavavej
Copy link
Member

Thanks for simplifying this code! ✨ 🪄 🎉

@StephanTLavavej StephanTLavavej mentioned this pull request Oct 26, 2023
Merged
@AlexGuteniev AlexGuteniev deleted the cats_and_tails branch October 26, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vector_algorithms.cpp: turn tails
3 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter