Skip to content

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Aug 5, 2023

Also make the deprecation of Microsoft extensions controlled by _SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS, which changes the controlling introduced in #3818.

Towards #282. (Not sure whether it should "fixed" at this moment).

Also make the deprecation of Microsoft extensions controlled by
`_SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS`.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner August 5, 2023 16:14
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Aug 5, 2023
@StephanTLavavej StephanTLavavej self-assigned this Aug 7, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed a small commit to slightly improve the grammar of the deprecation message, and a large commit that restored the tests/tr1/tests/cvt subdirectory and instead suppressed the warning via the conveniently-located env.lst there.

@StephanTLavavej StephanTLavavej removed their assignment Aug 8, 2023
@CaseyCarter CaseyCarter self-assigned this Aug 29, 2023
@CaseyCarter
Copy link
Contributor

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter merged commit 40e1eac into microsoft:main Aug 31, 2023
@CaseyCarter
Copy link
Contributor

Thanks for deprecating these headers that we never should have shipped in the first place ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants