Skip to content

Conversation

achabense
Copy link
Contributor

  • Remove all unnecessary typenames for <format> header (STL: Down with typename? #3718).
  • (Also, move _Is_slash_oper & _Is_slash downstream from <xfilesystem_abi.h> to <filesystem> as it is only needed there.)

@achabense achabense requested a review from a team as a code owner July 20, 2023 18:23
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor cleanup in pre-existing code, which I'll go ahead and push.

Remove extraneous comment
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Jul 20, 2023
@StephanTLavavej StephanTLavavej added format C++20/23 format filesystem C++17 filesystem labels Jul 20, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 20, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a2979f3 into microsoft:main Jul 26, 2023
@StephanTLavavej
Copy link
Member

Thanks for this cleanup and noticing the _Is_slash throughput improvement! 🧹 ✨ 🎉

@achabense achabense deleted the _Format_typename_cleanups branch July 30, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved filesystem C++17 filesystem format C++20/23 format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants