Skip to content

Conversation

StephanTLavavej
Copy link
Member

  • P2321R2_views_zip was using ranges as an identifier. 🙀 Rename this to rngs, avoiding confusion.
  • Dev09_192736_tr1_prngs_not_copyconstructible, written a billion years ago, also had ranges. While this isn't really a problem, let's add a d suffix (also to the following weights), which is consistent with the preceding and following vector<float> rangesf and vector<long double> rangesl.
  • Dev09_056375_locale_cleanup, written a trillion years ago, could use some extremely minor cleanups:
    • Add preprocessor comments.
    • Drop a totally unnecessary using-directive.
      • In general, we should be wary of changing tests in ways that could disturb what they were testing, but there is no way that this had any effect, being scoped to main().
    • Change a C cast to reinterpret_cast.

@StephanTLavavej StephanTLavavej added the test Related to test code label Mar 3, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 3, 2023 20:09
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Mar 3, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 7, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a9768b4 into microsoft:main Mar 7, 2023
@StephanTLavavej StephanTLavavej deleted the stl-cleanups-test-code branch March 7, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ranges C++20/23 ranges test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants