Skip to content

LWG-3851: chunk_view::inner-iterator missing custom iter_move and iter_swap #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2023
Merged

LWG-3851: chunk_view::inner-iterator missing custom iter_move and iter_swap #3517

merged 4 commits into from
Mar 4, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Mar 1, 2023 •
edited
Loading

Closes #3432.

@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review March 1, 2023 21:26
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 1, 2023 21:26
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Mar 1, 2023
StephanTLavavej
StephanTLavavej reviewed Mar 2, 2023
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Mar 2, 2023
@StephanTLavavej
Copy link
Member

I'm a greedy kitty who wants treats 😼 and is speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 994f941 into microsoft:main Mar 4, 2023
@StephanTLavavej
Copy link
Member

Thanks for the tasty LWG issue resolution! 🐈 😋 😻

@JMazurkiewicz JMazurkiewicz deleted the lwg3851 branch March 4, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3851 chunk_view::inner-iterator missing custom iter_move and iter_swap
3 participants
@JMazurkiewicz @StephanTLavavej @strega-nil-ms