Skip to content

fix codeql warnings #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix codeql warnings #3478

wants to merge 2 commits into from

Conversation

strega-nil-ms
Copy link
Contributor

@strega-nil-ms strega-nil-ms commented Feb 18, 2023 •
edited
Loading

Link to internal codeql bugs:

I'm still not sure if we should have these, and I'm unsure how to test these changes.

@strega-nil-ms strega-nil-ms requested a review from a team as a code owner February 18, 2023 01:09
@strega-nil-ms strega-nil-ms added the decision needed We need to choose something before working on this label Feb 18, 2023
AlexGuteniev
AlexGuteniev reviewed Feb 18, 2023
View reviewed changes
Copy link
Contributor

@AlexGuteniev AlexGuteniev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried more documented and common annotations, instead of some specific to a particular tool (I first time read about)?

CaseyCarter
CaseyCarter reviewed Feb 18, 2023
View reviewed changes
@strega-nil-ms strega-nil-ms deleted the strega-nil/codeql-bugs branch February 21, 2023 16:46
@strega-nil-ms strega-nil-ms mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter left review comments

@AlexGuteniev AlexGuteniev AlexGuteniev left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
decision needed We need to choose something before working on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strega-nil-ms @CaseyCarter @AlexGuteniev @strega-nil