Skip to content

<barrier>: Declare victory! #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2023
Merged

<barrier>: Declare victory! #3455

merged 5 commits into from
Feb 14, 2023

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Feb 12, 2023 •
edited
Loading

No lines in <barrier> were actually touched.

I have verified that we have no test coverage on guarantees we eliminate.

Resolves #3440

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner February 12, 2023 18:44
@StephanTLavavej
Copy link
Member

std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp is failing, otherwise this looks good to me.

@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Feb 12, 2023
JMazurkiewicz
JMazurkiewicz reviewed Feb 12, 2023
View reviewed changes
CaseyCarter
CaseyCarter approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push a change for my comment.

@StephanTLavavej StephanTLavavej self-assigned this Feb 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've resolved trivial adjacent-add conflicts in yvals_core.h and libcxx's expected_results.txt and skipped_tests.txt.

@StephanTLavavej StephanTLavavej merged commit 6b2fef2 into microsoft:main Feb 14, 2023
@StephanTLavavej
Copy link
Member

🥇 😻 🎉

@AlexGuteniev AlexGuteniev deleted the declare_victory branch February 14, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@JMazurkiewicz JMazurkiewicz JMazurkiewicz left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2588R3 barrier's Phase Completion Guarantees
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @JMazurkiewicz