Skip to content

Change _NODISCARD in source and test files to [[nodiscard]] #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2023
Merged

Change _NODISCARD in source and test files to [[nodiscard]] #3397

merged 1 commit into from
Feb 11, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #2272.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 7, 2023 16:17
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Feb 7, 2023
@StephanTLavavej StephanTLavavej self-assigned this Feb 10, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9ae1b3f into microsoft:main Feb 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for simplifying these parts of the codebase! 🎉 🐈 🐈‍⬛

@frederick-vs-ja frederick-vs-ja deleted the cleanup-nodiscard branch February 11, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider marking internal code as [[nodiscard]], not _NODISCARD
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter