Skip to content

Speculatively implement LWG-3867 #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2023
Merged

Speculatively implement LWG-3867 #3367

merged 2 commits into from
Feb 3, 2023

Conversation

CaseyCarter
Copy link
Contributor

Fixes #3355.

@CaseyCarter CaseyCarter added the enhancement Something can be improved label Jan 29, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner January 29, 2023 18:17
@StephanTLavavej StephanTLavavej mentioned this pull request Jan 29, 2023
Closed
@StephanTLavavej
Copy link
Member

I pushed a commit: 🐿️ 🐿️ 🐿️

@CaseyCarter
Copy link
Contributor Author

Thanks for the de-squirrel-ification @StephanTLavavej!

@StephanTLavavej StephanTLavavej self-assigned this Feb 2, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c1c1be4 into microsoft:main Feb 3, 2023
@CaseyCarter CaseyCarter deleted the lwg3867 branch February 3, 2023 00:45
@StephanTLavavej
Copy link
Member

🐿️

🐿️

🐿️

@CaseyCarter
Copy link
Contributor Author

Truly a shame that you folks reviewed this so quickly or we could have speculatively merged the speculative implementation of LWG-3867.

@CaseyCarter
Copy link
Contributor Author

Truly a shame that you folks reviewed this so quickly or we could have speculatively merged the speculative implementation of LWG-3867.

With that much speculation, we'd need Spectre mitigation in our codeflow process. 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<syncstream>: is_nothrow_move_assignable_v<osyncstream> is squirrelly 🐿️
3 participants
@CaseyCarter @StephanTLavavej @strega-nil-ms