Skip to content

Improve views::elements tests #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2023
Merged

Improve views::elements tests #3350

merged 1 commit into from
Jan 22, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Jan 16, 2023 •
edited
Loading

This PR:

  • Removes workarounds for VSO-1243263,
  • Adds tests for view_interface::cbegin and view_interface::cend.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner January 16, 2023 21:24
@StephanTLavavej StephanTLavavej added test Related to test code ranges C++20/23 ranges labels Jan 18, 2023
strega-nil-ms
strega-nil-ms approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like MSVC has fixed this issue, so looks good to me!

miscco
miscco approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see all those workarounds disappear finally

@StephanTLavavej StephanTLavavej self-assigned this Jan 21, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6bf1e98 into microsoft:main Jan 22, 2023
@StephanTLavavej
Copy link
Member

Thanks for transmuting these leaden elements tests into gold! 🪄 🪙 ✨

@JMazurkiewicz JMazurkiewicz deleted the const_elements branch January 22, 2023 11:51
@JMazurkiewicz JMazurkiewicz mentioned this pull request Feb 5, 2023
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@miscco miscco miscco approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
ranges C++20/23 ranges test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JMazurkiewicz @StephanTLavavej @miscco @strega-nil-ms