Skip to content

Use symbolic constants in implementation of stacktrace #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Use symbolic constants in implementation of stacktrace #3292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions stl/src/stacktrace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// clang-format off
#include <initguid.h> // should be before any header that includes <guiddef.h>
#include <DbgEng.h>
#include <DbgHelp.h>
#include <Shlwapi.h>
// clang-format on

Expand Down Expand Up @@ -104,23 +105,15 @@ namespace {
(void) debug_control->WaitForEvent(0, INFINITE);
}

constexpr ULONG add_options = 0x1 /* SYMOPT_CASE_INSENSITIVE */
| 0x2 /* SYMOPT_UNDNAME */
| 0x4 /* SYMOPT_DEFERRED_LOADS */
| 0x10 /* SYMOPT_LOAD_LINES */
| 0x20 /* SYMOPT_OMAP_FIND_NEAREST */
| 0x100 /* SYMOPT_FAIL_CRITICAL_ERRORS */
| 0x10000 /* SYMOPT_AUTO_PUBLICS */
| 0x80000 /* SYMOPT_NO_PROMPTS */;

constexpr ULONG remove_options = 0x8 /* SYMOPT_NO_CPP */
| 0x40 /* SYMOPT_LOAD_ANYTHING */
| 0x100 /* SYMOPT_NO_UNQUALIFIED_LOADS */
| 0x400 /* SYMOPT_EXACT_SYMBOLS */
| 0x1000 /* SYMOPT_IGNORE_NT_SYMPATH */
| 0x4000 /* SYMOPT_PUBLICS_ONLY */
| 0x8000 /* SYMOPT_NO_PUBLICS */
| 0x20000 /* SYMOPT_NO_IMAGE_SEARCH */;
constexpr ULONG add_options = SYMOPT_CASE_INSENSITIVE | SYMOPT_UNDNAME | SYMOPT_DEFERRED_LOADS
| SYMOPT_LOAD_LINES | SYMOPT_OMAP_FIND_NEAREST
| SYMOPT_FAIL_CRITICAL_ERRORS | SYMOPT_AUTO_PUBLICS
| SYMOPT_NO_PROMPTS;

constexpr ULONG remove_options = SYMOPT_NO_CPP | SYMOPT_LOAD_ANYTHING
| SYMOPT_NO_UNQUALIFIED_LOADS | SYMOPT_EXACT_SYMBOLS
| SYMOPT_IGNORE_NT_SYMPATH | SYMOPT_PUBLICS_ONLY
| SYMOPT_NO_PUBLICS | SYMOPT_NO_IMAGE_SEARCH;

(void) debug_symbols->AddSymbolOptions(add_options);
(void) debug_symbols->RemoveSymbolOptions(remove_options);
Expand Down